OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

qemu.py: Use iteritems rather than keys()

Browse Source 
Let's avoid creating an in-memory list of keys and query for each value
and use `iteritems` which is an iterator of key-value pairs.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20170818142613.32394-4-ldoktor@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Lukáš Doktor 2017-08-18 16:26:06 +02:00 committed by Eduardo Habkost
parent 2782fc517d
commit 7f33ca7878
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/qemu.py
View File

@ -200,11 +200,11 @@ class QEMUMachine(object):
def qmp(self, cmd, conv_keys=True, **args):
'''Invoke a QMP command and return the response dict'''
qmp_args = dict()
for key in args.keys():
for key, value in args.iteritems():
if conv_keys:
qmp_args[key.translate(self.underscore_to_dash)] = args[key]
qmp_args[key.translate(self.underscore_to_dash)] = value
else:
qmp_args[key] = args[key]
qmp_args[key] = value
return self._qmp.cmd(cmd, args=qmp_args)