iotests: 211: Remove duplication with VM.blockdev_create()
The blockdev_create() function in this test case adds an error check that skips the test in case of failure because of memory shortage, but provides otherwise the same functionality as VM.blockdev_create() from iotests.py. Make it a thin wrapper around the iotests.py function. Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
parent
6055cdf3d9
commit
7fe6bb7a34
@ -27,15 +27,9 @@ iotests.verify_image_format(supported_fmts=['vdi'])
|
||||
iotests.verify_protocol(supported=['file'])
|
||||
|
||||
def blockdev_create(vm, options):
|
||||
result = vm.qmp_log('blockdev-create', job_id='job0', options=options,
|
||||
filters=[iotests.filter_qmp_testfiles])
|
||||
|
||||
if 'return' in result:
|
||||
assert result['return'] == {}
|
||||
error = vm.run_job('job0')
|
||||
if error and 'Could not allocate bmap' in error:
|
||||
iotests.notrun('Insufficient memory')
|
||||
iotests.log("")
|
||||
error = vm.blockdev_create(options)
|
||||
if error and 'Could not allocate bmap' in error:
|
||||
iotests.notrun('Insufficient memory')
|
||||
|
||||
with iotests.FilePath('t.vdi') as disk_path, \
|
||||
iotests.VM() as vm:
|
||||
|
Loading…
Reference in New Issue
Block a user