ramfb: add sanity checks to ramfb_create_display_surface

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Message-id: 20200429115236.28709-6-kraxel@redhat.com
This commit is contained in:
Gerd Hoffmann 2020-04-29 13:52:35 +02:00
parent 19aaee2a65
commit 819c83e278
1 changed files with 6 additions and 0 deletions

View File

@ -15,6 +15,7 @@
#include "qapi/error.h"
#include "hw/loader.h"
#include "hw/display/ramfb.h"
#include "hw/display/bochs-vbe.h" /* for limits */
#include "ui/console.h"
#include "sysemu/reset.h"
@ -49,6 +50,11 @@ static DisplaySurface *ramfb_create_display_surface(int width, int height,
hwaddr size;
void *data;
if (width < 16 || width > VBE_DISPI_MAX_XRES ||
height < 16 || height > VBE_DISPI_MAX_YRES ||
format == 0 /* unknown format */)
return NULL;
if (linesize == 0) {
linesize = width * PIXMAN_FORMAT_BPP(format) / 8;
}