OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

char: do not double-close fd when failing to add client

Browse Source 
The caller is already closing the fd on failure.

Fixes: c3054a6e6a ("char: Factor out qmp_add_client() parts and move to chardev/")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230306122751.2355515-3-marcandre.lureau@redhat.com>
This commit is contained in:
Marc-André Lureau 2023-03-06 16:27:42 +04:00
parent 6d3b418a4e
commit 8467936e3d
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chardev/char.c
View File

@ -1175,12 +1175,10 @@ bool qmp_add_client_char(int fd, bool has_skipauth, bool skipauth,
if (!s) { if (!s) {
error_setg(errp, "protocol '%s' is invalid", protocol); error_setg(errp, "protocol '%s' is invalid", protocol);
close(fd);
return false; return false;
} }
if (qemu_chr_add_client(s, fd) < 0) { if (qemu_chr_add_client(s, fd) < 0) {
error_setg(errp, "failed to add client"); error_setg(errp, "failed to add client");
close(fd);
return false; return false;
} }
return true; return true;