OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

memory: Rename mem_begin/mem_commit/mem_add helpers

Browse Source 
This renames some helpers to reflect better what they do.

This should cause no behavioural change.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-Id: <20170921085110.25598-9-aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Alexey Kardashevskiy 2017-09-21 18:51:00 +10:00 committed by Paolo Bonzini
parent 9950322a59
commit 8629d3fcb7
3 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
exec.c
View File

@ -358,7 +358,7 @@ static void phys_page_compact(PhysPageEntry *lp, Node *nodes)
} }
} }
static void phys_page_compact_all(AddressSpaceDispatch *d, int nodes_nb) void address_space_dispatch_compact(AddressSpaceDispatch *d)
{ {
if (d->phys_map.skip) { if (d->phys_map.skip) {
phys_page_compact(&d->phys_map, d->map.nodes); phys_page_compact(&d->phys_map, d->map.nodes);
@ -1346,7 +1346,7 @@ static void register_multipage(FlatView *fv,
phys_page_set(d, start_addr >> TARGET_PAGE_BITS, num_pages, section_index); phys_page_set(d, start_addr >> TARGET_PAGE_BITS, num_pages, section_index);
} }
void mem_add(FlatView *fv, MemoryRegionSection *section) void flatview_add_to_dispatch(FlatView *fv, MemoryRegionSection *section)
{ {
MemoryRegionSection now = *section, remain = *section; MemoryRegionSection now = *section, remain = *section;
Int128 page_size = int128_make64(TARGET_PAGE_SIZE); Int128 page_size = int128_make64(TARGET_PAGE_SIZE);
@ -2672,9 +2672,8 @@ static void io_mem_init(void)
NULL, UINT64_MAX); NULL, UINT64_MAX);
} }
AddressSpaceDispatch *mem_begin(AddressSpace *as) AddressSpaceDispatch *address_space_dispatch_new(FlatView *fv)
{ {
FlatView *fv = address_space_to_flatview(as);
AddressSpaceDispatch *d = g_new0(AddressSpaceDispatch, 1); AddressSpaceDispatch *d = g_new0(AddressSpaceDispatch, 1);
uint16_t n; uint16_t n;
@ -2698,11 +2697,6 @@ void address_space_dispatch_free(AddressSpaceDispatch *d)
g_free(d); g_free(d);
} }
void mem_commit(AddressSpaceDispatch *d)
{
phys_page_compact_all(d, d->map.nodes_nb);
}
static void tcg_commit(MemoryListener *listener) static void tcg_commit(MemoryListener *listener)
{ {
CPUAddressSpace *cpuas; CPUAddressSpace *cpuas;

6
include/exec/memory-internal.h
View File

@ -27,9 +27,9 @@ extern const MemoryRegionOps unassigned_mem_ops;
bool memory_region_access_valid(MemoryRegion *mr, hwaddr addr, bool memory_region_access_valid(MemoryRegion *mr, hwaddr addr,
unsigned size, bool is_write); unsigned size, bool is_write);
void mem_add(FlatView *fv, MemoryRegionSection *section); void flatview_add_to_dispatch(FlatView *fv, MemoryRegionSection *section);
AddressSpaceDispatch *mem_begin(AddressSpace *as); AddressSpaceDispatch *address_space_dispatch_new(FlatView *fv);
void mem_commit(AddressSpaceDispatch *d); void address_space_dispatch_compact(AddressSpaceDispatch *d);
AddressSpaceDispatch *address_space_to_dispatch(AddressSpace *as); AddressSpaceDispatch *address_space_to_dispatch(AddressSpace *as);
AddressSpaceDispatch *flatview_to_dispatch(FlatView *fv); AddressSpaceDispatch *flatview_to_dispatch(FlatView *fv);

6
memory.c
View File

@ -910,13 +910,13 @@ static void address_space_update_topology(AddressSpace *as)
FlatView *new_view = generate_memory_topology(as->root); FlatView *new_view = generate_memory_topology(as->root);
int i; int i;
new_view->dispatch = mem_begin(as); new_view->dispatch = address_space_dispatch_new(new_view);
for (i = 0; i < new_view->nr; i++) { for (i = 0; i < new_view->nr; i++) {
MemoryRegionSection mrs = MemoryRegionSection mrs =
section_from_flat_range(&new_view->ranges[i], new_view); section_from_flat_range(&new_view->ranges[i], new_view);
mem_add(new_view, &mrs); flatview_add_to_dispatch(new_view, &mrs);
} }
mem_commit(new_view->dispatch); address_space_dispatch_compact(new_view->dispatch);
if (!QTAILQ_EMPTY(&as->listeners)) { if (!QTAILQ_EMPTY(&as->listeners)) {
address_space_update_topology_pass(as, old_view, new_view, false); address_space_update_topology_pass(as, old_view, new_view, false);