hw/misc/vmcoreinfo: Add comment about reset handler
The VM coreinfo device does not sit on a bus, so it won't be reset automatically. This is why it calls qemu_register_reset(). Add a comment about it, so we don't convert its reset handler to a DeviceReset method. Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Li Qiang <liq3ea@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20191010131527.32513-9-philmd@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
parent
f7030d0031
commit
88552b16f2
@ -61,6 +61,10 @@ static void vmcoreinfo_realize(DeviceState *dev, Error **errp)
|
||||
NULL, fw_cfg_vmci_write, s,
|
||||
&s->vmcoreinfo, sizeof(s->vmcoreinfo), false);
|
||||
|
||||
/*
|
||||
* This device requires to register a global reset because it is
|
||||
* not plugged to a bus (which, as its QOM parent, would reset it).
|
||||
*/
|
||||
qemu_register_reset(vmcoreinfo_reset, dev);
|
||||
vmcoreinfo_state = s;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user