qcow2: introduce qcow2_write_caches and qcow2_flush_caches
They will be used to avoid recursively taking s->lock during bdrv_open or bdrv_check. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Message-Id: <1516279431-30424-7-git-send-email-pbonzini@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
parent
f87e08f9e2
commit
8b220eb7c8
@ -1171,7 +1171,35 @@ void qcow2_free_any_clusters(BlockDriverState *bs, uint64_t l2_entry,
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
int coroutine_fn qcow2_write_caches(BlockDriverState *bs)
|
||||||
|
{
|
||||||
|
BDRVQcow2State *s = bs->opaque;
|
||||||
|
int ret;
|
||||||
|
|
||||||
|
ret = qcow2_cache_write(bs, s->l2_table_cache);
|
||||||
|
if (ret < 0) {
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (qcow2_need_accurate_refcounts(s)) {
|
||||||
|
ret = qcow2_cache_write(bs, s->refcount_block_cache);
|
||||||
|
if (ret < 0) {
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
int coroutine_fn qcow2_flush_caches(BlockDriverState *bs)
|
||||||
|
{
|
||||||
|
int ret = qcow2_write_caches(bs);
|
||||||
|
if (ret < 0) {
|
||||||
|
return ret;
|
||||||
|
}
|
||||||
|
|
||||||
|
return bdrv_flush(bs->file->bs);
|
||||||
|
}
|
||||||
|
|
||||||
/*********************************************************/
|
/*********************************************************/
|
||||||
/* snapshots and image creation */
|
/* snapshots and image creation */
|
||||||
|
@ -500,7 +500,7 @@ static int qcow2_mark_clean(BlockDriverState *bs)
|
|||||||
|
|
||||||
s->incompatible_features &= ~QCOW2_INCOMPAT_DIRTY;
|
s->incompatible_features &= ~QCOW2_INCOMPAT_DIRTY;
|
||||||
|
|
||||||
ret = bdrv_flush(bs);
|
ret = qcow2_flush_caches(bs);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
@ -530,7 +530,7 @@ int qcow2_mark_consistent(BlockDriverState *bs)
|
|||||||
BDRVQcow2State *s = bs->opaque;
|
BDRVQcow2State *s = bs->opaque;
|
||||||
|
|
||||||
if (s->incompatible_features & QCOW2_INCOMPAT_CORRUPT) {
|
if (s->incompatible_features & QCOW2_INCOMPAT_CORRUPT) {
|
||||||
int ret = bdrv_flush(bs);
|
int ret = qcow2_flush_caches(bs);
|
||||||
if (ret < 0) {
|
if (ret < 0) {
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
@ -3647,22 +3647,10 @@ static coroutine_fn int qcow2_co_flush_to_os(BlockDriverState *bs)
|
|||||||
int ret;
|
int ret;
|
||||||
|
|
||||||
qemu_co_mutex_lock(&s->lock);
|
qemu_co_mutex_lock(&s->lock);
|
||||||
ret = qcow2_cache_write(bs, s->l2_table_cache);
|
ret = qcow2_write_caches(bs);
|
||||||
if (ret < 0) {
|
|
||||||
qemu_co_mutex_unlock(&s->lock);
|
|
||||||
return ret;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (qcow2_need_accurate_refcounts(s)) {
|
|
||||||
ret = qcow2_cache_write(bs, s->refcount_block_cache);
|
|
||||||
if (ret < 0) {
|
|
||||||
qemu_co_mutex_unlock(&s->lock);
|
|
||||||
return ret;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
qemu_co_mutex_unlock(&s->lock);
|
qemu_co_mutex_unlock(&s->lock);
|
||||||
|
|
||||||
return 0;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
static BlockMeasureInfo *qcow2_measure(QemuOpts *opts, BlockDriverState *in_bs,
|
static BlockMeasureInfo *qcow2_measure(QemuOpts *opts, BlockDriverState *in_bs,
|
||||||
|
@ -576,6 +576,8 @@ void qcow2_free_any_clusters(BlockDriverState *bs, uint64_t l2_entry,
|
|||||||
int qcow2_update_snapshot_refcount(BlockDriverState *bs,
|
int qcow2_update_snapshot_refcount(BlockDriverState *bs,
|
||||||
int64_t l1_table_offset, int l1_size, int addend);
|
int64_t l1_table_offset, int l1_size, int addend);
|
||||||
|
|
||||||
|
int coroutine_fn qcow2_flush_caches(BlockDriverState *bs);
|
||||||
|
int coroutine_fn qcow2_write_caches(BlockDriverState *bs);
|
||||||
int qcow2_check_refcounts(BlockDriverState *bs, BdrvCheckResult *res,
|
int qcow2_check_refcounts(BlockDriverState *bs, BdrvCheckResult *res,
|
||||||
BdrvCheckMode fix);
|
BdrvCheckMode fix);
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user