checkpatch: complain about ffs(3) calls
The ffs(3) family of functions is not portable. MinGW doesn't always provide the function. Use ctz32() or ctz64() instead. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Message-id: 1427124571-28598-10-git-send-email-stefanha@redhat.com Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
parent
f450a85899
commit
8b6ee9aeb3
|
@ -2911,6 +2911,17 @@ sub process {
|
||||||
if ($rawline =~ /\b(?:Qemu|QEmu)\b/) {
|
if ($rawline =~ /\b(?:Qemu|QEmu)\b/) {
|
||||||
WARN("use QEMU instead of Qemu or QEmu\n" . $herecurr);
|
WARN("use QEMU instead of Qemu or QEmu\n" . $herecurr);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
# check for non-portable ffs() calls that have portable alternatives in QEMU
|
||||||
|
if ($line =~ /\bffs\(/) {
|
||||||
|
ERROR("use ctz32() instead of ffs()\n" . $herecurr);
|
||||||
|
}
|
||||||
|
if ($line =~ /\bffsl\(/) {
|
||||||
|
ERROR("use ctz32() or ctz64() instead of ffsl()\n" . $herecurr);
|
||||||
|
}
|
||||||
|
if ($line =~ /\bffsll\(/) {
|
||||||
|
ERROR("use ctz64() instead of ffsll()\n" . $herecurr);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
# If we have no input at all, then there is nothing to report on
|
# If we have no input at all, then there is nothing to report on
|
||||||
|
|
Loading…
Reference in New Issue