OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

dump: Rename qmp_dump_guest_memory() parameter to match QAPI schema

Browse Source 
The name of the second parameter differs between QAPI schema and C
implementation: it's @protocol in the former and @file in the latter.
Potentially confusing.  Change the C implementation to match the QAPI
schema.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20231031104531.3169721-2-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2023-10-31 11:45:27 +01:00 committed by Marc-André Lureau
parent e6549197f7
commit 8beaeed734
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
dump/dump.c
View File

@ -2079,11 +2079,12 @@ DumpQueryResult *qmp_query_dump(Error **errp)
return result;
}
void qmp_dump_guest_memory(bool paging, const char *file,
void qmp_dump_guest_memory(bool paging, const char *protocol,
bool has_detach, bool detach,
bool has_begin, int64_t begin, bool has_length,
int64_t length, bool has_format,
DumpGuestMemoryFormat format, Error **errp)
bool has_begin, int64_t begin,
bool has_length, int64_t length,
bool has_format, DumpGuestMemoryFormat format,
Error **errp)
{
ERRP_GUARD();
const char *p;
@ -2170,7 +2171,7 @@ void qmp_dump_guest_memory(bool paging, const char *file,
}
#if !defined(WIN32)
if (strstart(file, "fd:", &p)) {
if (strstart(protocol, "fd:", &p)) {
fd = monitor_get_fd(monitor_cur(), p, errp);
if (fd == -1) {
return;
@ -2178,7 +2179,7 @@ void qmp_dump_guest_memory(bool paging, const char *file,
}
#endif
if (strstart(file, "file:", &p)) {
if (strstart(protocol, "file:", &p)) {
fd = qemu_open_old(p, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, S_IRUSR);
if (fd < 0) {
error_setg_file_open(errp, errno, p);