tests/migration: Add a test for auto converge

Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190909131335.16848-4-yury-kotov@yandex-team.ru>
[Reorganize check_migration_status for rebase. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Yury Kotov 2019-09-09 16:13:35 +03:00 committed by Paolo Bonzini
parent 87287ac02c
commit 8c51642b42
1 changed files with 138 additions and 19 deletions

View File

@ -240,6 +240,17 @@ static int64_t read_ram_property_int(QTestState *who, const char *property)
return result; return result;
} }
static int64_t read_migrate_property_int(QTestState *who, const char *property)
{
QDict *rsp_return;
int64_t result;
rsp_return = migrate_query(who);
result = qdict_get_try_int(rsp_return, property, 0);
qobject_unref(rsp_return);
return result;
}
static uint64_t get_migration_pass(QTestState *who) static uint64_t get_migration_pass(QTestState *who)
{ {
return read_ram_property_int(who, "dirty-sync-count"); return read_ram_property_int(who, "dirty-sync-count");
@ -254,32 +265,46 @@ static void read_blocktime(QTestState *who)
qobject_unref(rsp_return); qobject_unref(rsp_return);
} }
static bool check_migration_status(QTestState *who, const char *goal,
const char **ungoals)
{
bool ready;
char *current_status;
const char **ungoal;
current_status = migrate_query_status(who);
ready = strcmp(current_status, goal) == 0;
if (!ungoals) {
g_assert_cmpstr(current_status, !=, "failed");
/*
* If looking for a state other than completed,
* completion of migration would cause the test to
* hang.
*/
if (strcmp(goal, "completed") != 0) {
g_assert_cmpstr(current_status, !=, "completed");
}
} else {
for (ungoal = ungoals; *ungoal; ungoal++) {
g_assert_cmpstr(current_status, !=, *ungoal);
}
}
g_free(current_status);
return ready;
}
static void wait_for_migration_status(QTestState *who, static void wait_for_migration_status(QTestState *who,
const char *goal, const char *goal,
const char **ungoals) const char **ungoals)
{ {
while (true) { while (!check_migration_status(who, goal, ungoals)) {
bool completed;
char *status;
const char **ungoal;
status = migrate_query_status(who);
completed = strcmp(status, goal) == 0;
for (ungoal = ungoals; *ungoal; ungoal++) {
g_assert_cmpstr(status, !=, *ungoal);
}
g_free(status);
if (completed) {
return;
}
usleep(1000); usleep(1000);
} }
} }
static void wait_for_migration_complete(QTestState *who) static void wait_for_migration_complete(QTestState *who)
{ {
wait_for_migration_status(who, "completed", wait_for_migration_status(who, "completed", NULL);
(const char * []) { "failed", NULL });
} }
static void wait_for_migration_pass(QTestState *who) static void wait_for_migration_pass(QTestState *who)
@ -450,6 +475,17 @@ static void migrate_pause(QTestState *who)
qobject_unref(rsp); qobject_unref(rsp);
} }
static void migrate_continue(QTestState *who, const char *state)
{
QDict *rsp;
rsp = wait_command(who,
"{ 'execute': 'migrate-continue',"
" 'arguments': { 'state': %s } }",
state);
qobject_unref(rsp);
}
static void migrate_recover(QTestState *who, const char *uri) static void migrate_recover(QTestState *who, const char *uri)
{ {
QDict *rsp; QDict *rsp;
@ -814,9 +850,7 @@ static void test_postcopy_recovery(void)
* Wait until postcopy is really started; we can only run the * Wait until postcopy is really started; we can only run the
* migrate-pause command during a postcopy * migrate-pause command during a postcopy
*/ */
wait_for_migration_status(from, "postcopy-active", wait_for_migration_status(from, "postcopy-active", NULL);
(const char * []) { "failed",
"completed", NULL });
/* /*
* Manually stop the postcopy migration. This emulates a network * Manually stop the postcopy migration. This emulates a network
@ -1210,6 +1244,89 @@ static void test_validate_uuid_dst_not_set(void)
false, true); false, true);
} }
static void test_migrate_auto_converge(void)
{
char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
QTestState *from, *to;
int64_t remaining, percentage;
/*
* We want the test to be stable and as fast as possible.
* E.g., with 1Gb/s bandwith migration may pass without throttling,
* so we need to decrease a bandwidth.
*/
const int64_t init_pct = 5, inc_pct = 50, max_pct = 95;
const int64_t max_bandwidth = 400000000; /* ~400Mb/s */
const int64_t downtime_limit = 250; /* 250ms */
/*
* We migrate through unix-socket (> 500Mb/s).
* Thus, expected migration speed ~= bandwidth limit (< 500Mb/s).
* So, we can predict expected_threshold
*/
const int64_t expected_threshold = max_bandwidth * downtime_limit / 1000;
if (test_migrate_start(&from, &to, uri, false, false, NULL, NULL)) {
return;
}
migrate_set_capability(from, "auto-converge", true);
migrate_set_parameter_int(from, "cpu-throttle-initial", init_pct);
migrate_set_parameter_int(from, "cpu-throttle-increment", inc_pct);
migrate_set_parameter_int(from, "max-cpu-throttle", max_pct);
/*
* Set the initial parameters so that the migration could not converge
* without throttling.
*/
migrate_set_parameter_int(from, "downtime-limit", 1);
migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* ~100Mb/s */
/* To check remaining size after precopy */
migrate_set_capability(from, "pause-before-switchover", true);
/* Wait for the first serial output from the source */
wait_for_serial("src_serial");
migrate(from, uri, "{}");
/* Wait for throttling begins */
percentage = 0;
while (percentage == 0) {
percentage = read_migrate_property_int(from, "cpu-throttle-percentage");
usleep(100);
g_assert_false(got_stop);
}
/* The first percentage of throttling should be equal to init_pct */
g_assert_cmpint(percentage, ==, init_pct);
/* Now, when we tested that throttling works, let it converge */
migrate_set_parameter_int(from, "downtime-limit", downtime_limit);
migrate_set_parameter_int(from, "max-bandwidth", max_bandwidth);
/*
* Wait for pre-switchover status to check last throttle percentage
* and remaining. These values will be zeroed later
*/
wait_for_migration_status(from, "pre-switchover", NULL);
/* The final percentage of throttling shouldn't be greater than max_pct */
percentage = read_migrate_property_int(from, "cpu-throttle-percentage");
g_assert_cmpint(percentage, <=, max_pct);
remaining = read_ram_property_int(from, "remaining");
g_assert_cmpint(remaining, <, expected_threshold);
migrate_continue(from, "pre-switchover");
qtest_qmp_eventwait(to, "RESUME");
wait_for_serial("dest_serial");
wait_for_migration_complete(from);
g_free(uri);
test_migrate_end(from, to, true);
}
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
char template[] = "/tmp/migration-test-XXXXXX"; char template[] = "/tmp/migration-test-XXXXXX";
@ -1272,6 +1389,8 @@ int main(int argc, char **argv)
qtest_add_func("/migration/validate_uuid_dst_not_set", qtest_add_func("/migration/validate_uuid_dst_not_set",
test_validate_uuid_dst_not_set); test_validate_uuid_dst_not_set);
qtest_add_func("/migration/auto_converge", test_migrate_auto_converge);
ret = g_test_run(); ret = g_test_run();
g_assert_cmpint(ret, ==, 0); g_assert_cmpint(ret, ==, 0);