OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

tpm: fix crash when FD >= 1024 and unnecessary errors due to EINTR

Browse Source 
Replace select() with poll() to fix a crash when QEMU has a large number
of FDs. Also use RETRY_ON_EINTR to avoid unnecessary errors due to EINTR.

Cc: qemu-stable@nongnu.org
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2020133
Fixes: 56a3c24ffc ("tpm: Probe for connected TPM 1.2 or TPM 2")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
This commit is contained in:
Marc-André Lureau 2023-09-11 17:25:51 +04:00 committed by Stefan Berger
parent 9ef497755a
commit 8e32ddff69
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
backends/tpm/tpm_util.c
View File

@ -112,12 +112,8 @@ static int tpm_util_request(int fd,
void *response, void *response,
size_t responselen) size_t responselen)
{ {
fd_set readfds; GPollFD fds[1] = { {.fd = fd, .events = G_IO_IN } };
int n; int n;
struct timeval tv = {
.tv_sec = 1,
.tv_usec = 0,
};
n = write(fd, request, requestlen); n = write(fd, request, requestlen);
if (n < 0) { if (n < 0) {
@ -127,11 +123,8 @@ static int tpm_util_request(int fd,
return -EFAULT; return -EFAULT;
} }
FD_ZERO(&readfds);
FD_SET(fd, &readfds);
/* wait for a second */ /* wait for a second */
n = select(fd + 1, &readfds, NULL, NULL, &tv); n = RETRY_ON_EINTR(g_poll(fds, 1, 1000));
if (n != 1) { if (n != 1) {
return -errno; return -errno;
} }