virtio-9p: avoid unwarranted uses of strncpy

In all of these cases, the uses of strncpy were unnecessary, since
at each point of use we know that the NUL-terminated source bytes
fit in the destination buffer.  Use memcpy in place of strncpy.

Acked-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Jim Meyering 2012-10-04 13:09:56 +02:00 committed by Anthony Liguori
parent e5fda03839
commit 9238c2099d
3 changed files with 8 additions and 4 deletions

View File

@ -44,7 +44,8 @@ static ssize_t mp_pacl_listxattr(FsContext *ctx, const char *path,
return -1; return -1;
} }
strncpy(value, ACL_ACCESS, len); /* len includes the trailing NUL */
memcpy(value, ACL_ACCESS, len);
return 0; return 0;
} }
@ -95,7 +96,8 @@ static ssize_t mp_dacl_listxattr(FsContext *ctx, const char *path,
return -1; return -1;
} }
strncpy(value, ACL_DEFAULT, len); /* len includes the trailing NUL */
memcpy(value, ACL_ACCESS, len);
return 0; return 0;
} }

View File

@ -61,7 +61,8 @@ static ssize_t mp_user_listxattr(FsContext *ctx, const char *path,
return -1; return -1;
} }
strncpy(value, name, name_size); /* name_size includes the trailing NUL. */
memcpy(value, name, name_size);
return name_size; return name_size;
} }

View File

@ -53,7 +53,8 @@ ssize_t pt_listxattr(FsContext *ctx, const char *path,
return -1; return -1;
} }
strncpy(value, name, name_size); /* no need for strncpy: name_size is strlen(name)+1 */
memcpy(value, name, name_size);
return name_size; return name_size;
} }