OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

coroutine: reserve 5,000 mappings

Browse Source 
Daniel P. Berrangé <berrange@redhat.com> pointed out that the coroutine
pool size heuristic is very conservative. Instead of halving
max_map_count, he suggested reserving 5,000 mappings for non-coroutine
users based on observations of guests he has access to.

Fixes: 86a637e481 ("coroutine: cap per-thread local pool size")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20240320181232.1464819-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Stefan Hajnoczi 2024-03-20 14:12:32 -04:00
parent fea445e8fe
commit 9352f80cd9
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
util/qemu-coroutine.c
View File

@ -377,12 +377,17 @@ static unsigned int get_global_pool_hard_max_size(void)
NULL) && NULL) &&
qemu_strtoi(contents, NULL, 10, &max_map_count) == 0) { qemu_strtoi(contents, NULL, 10, &max_map_count) == 0) {
/* /*
* This is a conservative upper bound that avoids exceeding * This is an upper bound that avoids exceeding max_map_count. Leave a
* max_map_count. Leave half for non-coroutine users like library * fixed amount for non-coroutine users like library dependencies,
* dependencies, vhost-user, etc. Each coroutine takes up 2 VMAs so * vhost-user, etc. Each coroutine takes up 2 VMAs so halve the
* halve the amount again. * remaining amount.
*/ */
return max_map_count / 4; if (max_map_count > 5000) {
return (max_map_count - 5000) / 2;
} else {
/* Disable the global pool but threads still have local pools */
return 0;
}
} }
#endif #endif