OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

aspeed: remove useless comment on controller segment size

Browse Source 
The flash devices used for the FMC controller (BMC firmware) are well
defined for each Aspeed machine and are all smaller than the default
mapping window size, at least for CE0 which is the chip the SoC boots
from.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 1486648058-520-3-git-send-email-clg@kaod.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Cédric Le Goater 2017-02-10 17:40:29 +00:00 committed by Peter Maydell
parent 0c7209bee8
commit 93bf276d5f
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hw/arm/aspeed.c
View File

@ -148,10 +148,6 @@ static void aspeed_board_init_flashes(AspeedSMCState *s, const char *flashtype,
DriveInfo *dinfo = drive_get_next(IF_MTD); DriveInfo *dinfo = drive_get_next(IF_MTD);
qemu_irq cs_line; qemu_irq cs_line;
/*
* FIXME: check that we are not using a flash module exceeding
* the controller segment size
*/
fl->flash = ssi_create_slave_no_init(s->spi, flashtype); fl->flash = ssi_create_slave_no_init(s->spi, flashtype);
if (dinfo) { if (dinfo) {
qdev_prop_set_drive(fl->flash, "drive", blk_by_legacy_dinfo(dinfo), qdev_prop_set_drive(fl->flash, "drive", blk_by_legacy_dinfo(dinfo),
@ -210,7 +206,9 @@ static void aspeed_board_init(MachineState *machine,
/* /*
* create a ROM region using the default mapping window size of * create a ROM region using the default mapping window size of
* the flash module. * the flash module. The window size is 64MB for the AST2400
* SoC and 128MB for the AST2500 SoC, which is twice as big as
* needed by the flash modules of the Aspeed machines.
*/ */
memory_region_init_rom(boot_rom, OBJECT(bmc), "aspeed.boot_rom", memory_region_init_rom(boot_rom, OBJECT(bmc), "aspeed.boot_rom",
fl->size, &error_abort); fl->size, &error_abort);