OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

block: bdrv_insert_node(): doc and style

Browse Source 
- options & flags is common pair for open-like functions, let's use it
 - add a comment that specifies use of @options

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210920115538.264372-4-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Vladimir Sementsov-Ogievskiy 2021-09-20 14:55:36 +03:00 committed by Kevin Wolf
parent f053b7e800
commit 96796fae6f
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
block.c
View File

@ -5119,14 +5119,23 @@ static void bdrv_delete(BlockDriverState *bs)
g_free(bs); g_free(bs);
} }
BlockDriverState *bdrv_insert_node(BlockDriverState *bs, QDict *node_options,
/*
* Replace @bs by newly created block node.
*
* @options is a QDict of options to pass to the block drivers, or NULL for an
* empty set of options. The reference to the QDict belongs to the block layer
* after the call (even on failure), so if the caller intends to reuse the
* dictionary, it needs to use qobject_ref() before calling bdrv_open.
*/
BlockDriverState *bdrv_insert_node(BlockDriverState *bs, QDict *options,
int flags, Error **errp) int flags, Error **errp)
{ {
ERRP_GUARD(); ERRP_GUARD();
int ret; int ret;
BlockDriverState *new_node_bs; BlockDriverState *new_node_bs;
new_node_bs = bdrv_open(NULL, NULL, node_options, flags, errp); new_node_bs = bdrv_open(NULL, NULL, options, flags, errp);
if (new_node_bs == NULL) { if (new_node_bs == NULL) {
error_prepend(errp, "Could not create node: "); error_prepend(errp, "Could not create node: ");
return NULL; return NULL;