virtio-crypto: fix uninitialized variables
Though crypto_cfg.reserve is an unused field, let me initialize the structure in order to make coverity happy. *** CID 1365923: Uninitialized variables (UNINIT) /hw/virtio/virtio-crypto.c: 851 in virtio_crypto_get_config() 845 stl_le_p(&crypto_cfg.mac_algo_h, c->conf.mac_algo_h); 846 stl_le_p(&crypto_cfg.aead_algo, c->conf.aead_algo); 847 stl_le_p(&crypto_cfg.max_cipher_key_len, c->conf.max_cipher_key_len); 848 stl_le_p(&crypto_cfg.max_auth_key_len, c->conf.max_auth_key_len); 849 stq_le_p(&crypto_cfg.max_size, c->conf.max_size); 850 >>> CID 1365923: Uninitialized variables (UNINIT) >>> Using uninitialized value "crypto_cfg". Field "crypto_cfg.reserve" is uninitialized when calling "memcpy". [Note: The source code implementation of the function has been overridden by a builtin model.] 851 memcpy(config, &crypto_cfg, c->config_size); 852 } 853 Rported-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Gonglei <arei.gonglei@huawei.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
parent
1b57bd4f2f
commit
9730280d54
|
@ -838,7 +838,7 @@ static Property virtio_crypto_properties[] = {
|
|||
static void virtio_crypto_get_config(VirtIODevice *vdev, uint8_t *config)
|
||||
{
|
||||
VirtIOCrypto *c = VIRTIO_CRYPTO(vdev);
|
||||
struct virtio_crypto_config crypto_cfg;
|
||||
struct virtio_crypto_config crypto_cfg = {};
|
||||
|
||||
/*
|
||||
* Virtio-crypto device conforms to VIRTIO 1.0 which is always LE,
|
||||
|
|
Loading…
Reference in New Issue