OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

syscall: fixed mincore(2) not failing with ENOMEM

Browse Source 
The current implementation of the mincore(2) syscall sets errno to
EFAULT when the region identified by the first two parameters is
invalid.

This goes against the man page specification, where mincore(2) should
only fail with EFAULT when the third parameter is an invalid address;
and fail with ENOMEM when the checked region does not point to mapped
memory.

Signed-off-by: Franklin "Snaipe" Mathieu <snaipe@diacritic.io>
Cc: Riku Voipio <riku.voipio@linaro.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20170217085800.28873-2-snaipe@diacritic.io>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Franklin \"Snaipe\" Mathieu 2017-02-17 08:58:00 +00:00 committed by Laurent Vivier
parent 59ebb6e451
commit 98a3331a55
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
linux-user/syscall.c
View File

@ -11194,11 +11194,16 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
case TARGET_NR_mincore: case TARGET_NR_mincore:
{ {
void *a; void *a;
ret = -TARGET_ENOMEM;
a = lock_user(VERIFY_READ, arg1, arg2, 0);
if (!a) {
goto fail;
}
ret = -TARGET_EFAULT; ret = -TARGET_EFAULT;
if (!(a = lock_user(VERIFY_READ, arg1,arg2, 0))) p = lock_user_string(arg3);
goto efault; if (!p) {
if (!(p = lock_user_string(arg3)))
goto mincore_fail; goto mincore_fail;
}
ret = get_errno(mincore(a, arg2, p)); ret = get_errno(mincore(a, arg2, p));
unlock_user(p, arg3, ret); unlock_user(p, arg3, ret);
mincore_fail: mincore_fail: