OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts

Browse Source 
A regression in commit 15c2f669e caused us to silently ignore
excess input to the QemuOpts visitor.  Later, commit ea4641
accidentally abused that situation, by removing "qom-type" and
"id" from the corresponding QDict but leaving them defined in
the QemuOpts, when using the pair of containers to create a
user-defined object. Note that since we are already traversing
two separate items (a QDict and a QemuOpts), we are already
able to flag bogus arguments, as in:

$ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio -object memory-backend-ram,id=mem1,size=4k,bogus=huh
qemu-system-x86_64: -object memory-backend-ram,id=mem1,size=4k,bogus=huh: Property '.bogus' not found

So the only real concern is that when we re-enable strict checking
in the QemuOpts visitor, we do not want to start flagging the two
leftover keys as unvisited.  Rearrange the code to clean out the
QemuOpts listing in advance, rather than removing items from the
QDict.  Since "qom-type" is usually an automatic implicit default,
we don't have to restore it (this does mean that once instantiated,
QemuOpts is not necessarily an accurate representation of the
original command line - but this is not the first place to do that);
however "id" has to be put back (requiring us to cast away a const).

[As a side note, hmp_object_add() turns a QDict into a QemuOpts,
then calls user_creatable_add_opts() which converts QemuOpts into
a new QDict. There are probably a lot of wasteful conversions like
this, but cleaning them up is a much bigger task than the immediate
regression fix.]

CC: qemu-stable@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20170322144525.18964-3-eblake@redhat.com>
Tested-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
Eric Blake 2017-03-22 09:45:24 -05:00 committed by Markus Armbruster
parent 76861f6bef
commit 9a6d1acb3e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qom/object_interfaces.c
View File

@ -114,7 +114,7 @@ Object *user_creatable_add_opts(QemuOpts *opts, Error **errp)
QDict *pdict; QDict *pdict;
Object *obj; Object *obj;
const char *id = qemu_opts_id(opts); const char *id = qemu_opts_id(opts);
const char *type = qemu_opt_get(opts, "qom-type"); char *type = qemu_opt_get_del(opts, "qom-type");
if (!type) { if (!type) {
error_setg(errp, QERR_MISSING_PARAMETER, "qom-type"); error_setg(errp, QERR_MISSING_PARAMETER, "qom-type");
@ -122,17 +122,19 @@ Object *user_creatable_add_opts(QemuOpts *opts, Error **errp)
} }
if (!id) { if (!id) {
error_setg(errp, QERR_MISSING_PARAMETER, "id"); error_setg(errp, QERR_MISSING_PARAMETER, "id");
g_free(type);
return NULL; return NULL;
} }
qemu_opts_set_id(opts, NULL);
pdict = qemu_opts_to_qdict(opts, NULL); pdict = qemu_opts_to_qdict(opts, NULL);
qdict_del(pdict, "qom-type");
qdict_del(pdict, "id");
v = opts_visitor_new(opts); v = opts_visitor_new(opts);
obj = user_creatable_add_type(type, id, pdict, v, errp); obj = user_creatable_add_type(type, id, pdict, v, errp);
visit_free(v); visit_free(v);
qemu_opts_set_id(opts, (char *) id);
g_free(type);
QDECREF(pdict); QDECREF(pdict);
return obj; return obj;
} }