OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

QOM: Fail casts for unknown types

Browse Source 
When we try to cast an object to an unknown type, fail the cast. Today
we would simply run into an assert().

This fixes a bug on qemu-system-s390x for me that gets triggered by the
audio code looking for PCI and ISA buses.

Signed-off-by: Alexander Graf <agraf@suse.de>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1367326936-28539-1-git-send-email-agraf@suse.de
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Alexander Graf 2013-04-30 15:02:16 +02:00 committed by Anthony Liguori
parent b7da6c6081
commit 9ab880b3a2
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
qom/object.c
View File

@ -453,6 +453,11 @@ ObjectClass *object_class_dynamic_cast(ObjectClass *class,
TypeImpl *type = class->type; TypeImpl *type = class->type;
ObjectClass *ret = NULL; ObjectClass *ret = NULL;
if (!target_type) {
/* target class type unknown, so fail the cast */
return NULL;
}
if (type->class->interfaces && if (type->class->interfaces &&
type_is_ancestor(target_type, type_interface)) { type_is_ancestor(target_type, type_interface)) {
int found = 0; int found = 0;