OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

qdev-monitor: Make device options help nicer

Browse Source 
Just like in qemu_opts_print_help(), print the device name as a caption
instead of on every single line, indent all options, add angle brackets
around types, and align the descriptions after 24 characters.  Also,
separate the descriptions with " - " instead of putting them in
parentheses, because that is what we do everywhere else.  This does look
a bit funny here because basically all bits have the description
"on/off", but funny does not mean it is less readable.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Max Reitz 2018-10-19 18:49:27 +02:00 committed by Kevin Wolf
parent 8513ec28be
commit 9c2762b406
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
qdev-monitor.c
View File

@ -285,10 +285,19 @@ int qdev_device_help(QemuOpts *opts)
goto error;
}
if (prop_list) {
out_printf("%s options:\n", driver);
} else {
out_printf("There are no options for %s.\n", driver);
}
for (prop = prop_list; prop; prop = prop->next) {
out_printf("%s.%s=%s", driver, prop->value->name, prop->value->type);
int len;
out_printf(" %s=<%s>%n", prop->value->name, prop->value->type, &len);
if (prop->value->has_description) {
out_printf(" (%s)\n", prop->value->description);
if (len < 24) {
out_printf("%*s", 24 - len, "");
}
out_printf(" - %s\n", prop->value->description);
} else {
out_printf("\n");
}