OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

COLO: Move some trace code behind qemu_mutex_unlock_iothread()

Browse Source 
There is no need to put some trace code in the critical section.
So, moving it behind qemu_mutex_unlock_iothread() can reduce the
lock time.

Signed-off-by: Lei Rao <lei.rao@intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
This commit is contained in:
Rao, Lei 2021-12-15 01:19:45 +08:00 committed by Juan Quintela
parent 077fbb5942
commit 9c5c8ff24e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
migration/colo.c
View File

@ -680,8 +680,8 @@ static void colo_incoming_process_checkpoint(MigrationIncomingState *mis,
qemu_mutex_lock_iothread(); qemu_mutex_lock_iothread();
vm_stop_force_state(RUN_STATE_COLO); vm_stop_force_state(RUN_STATE_COLO);
trace_colo_vm_state_change("run", "stop");
qemu_mutex_unlock_iothread(); qemu_mutex_unlock_iothread();
trace_colo_vm_state_change("run", "stop");
/* FIXME: This is unnecessary for periodic checkpoint mode */ /* FIXME: This is unnecessary for periodic checkpoint mode */
colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_REPLY, colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_REPLY,
@ -783,8 +783,8 @@ static void colo_incoming_process_checkpoint(MigrationIncomingState *mis,
vmstate_loading = false; vmstate_loading = false;
vm_start(); vm_start();
trace_colo_vm_state_change("stop", "run");
qemu_mutex_unlock_iothread(); qemu_mutex_unlock_iothread();
trace_colo_vm_state_change("stop", "run");
if (failover_get_state() == FAILOVER_STATUS_RELAUNCH) { if (failover_get_state() == FAILOVER_STATUS_RELAUNCH) {
return; return;
@ -887,8 +887,8 @@ void *colo_process_incoming_thread(void *opaque)
abort(); abort();
#endif #endif
vm_start(); vm_start();
trace_colo_vm_state_change("stop", "run");
qemu_mutex_unlock_iothread(); qemu_mutex_unlock_iothread();
trace_colo_vm_state_change("stop", "run");
colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_READY, colo_send_message(mis->to_src_file, COLO_MESSAGE_CHECKPOINT_READY,
&local_err); &local_err);