etraxfs_eth: correct use of ! and &
Combining bitwise AND and logical NOT is suspicious. Fixed by this Coccinelle script: // From http://article.gmane.org/gmane.linux.kernel/646367 @@ expression E1,E2; @@ ( !E1 & !E2 | - !E1 & E2 + !(E1 & E2) ) Acked-by: Edgar E. Iglesias <edgar.iglesias@gmail.com> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
This commit is contained in:
parent
8aa80ff82f
commit
9e84a4708f
@ -464,7 +464,7 @@ static int eth_match_groupaddr(struct fs_eth *eth, const unsigned char *sa)
|
||||
|
||||
/* First bit on the wire of a MAC address signals multicast or
|
||||
physical address. */
|
||||
if (!m_individual && !sa[0] & 1)
|
||||
if (!m_individual && !(sa[0] & 1))
|
||||
return 0;
|
||||
|
||||
/* Calculate the hash index for the GA registers. */
|
||||
|
Loading…
Reference in New Issue
Block a user