block: avoid duplicating filename string in bdrv_create
We know that the string will stay around until the function returns, and the parameter of drv->bdrv_co_create_opts is const char*, so it must not be modified either. Suggested-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Message-Id: <20221128142337.657646-7-eesposit@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
parent
f7f93a478a
commit
a212e675cd
7
block.c
7
block.c
|
@ -551,7 +551,7 @@ int bdrv_create(BlockDriver *drv, const char* filename,
|
|||
Coroutine *co;
|
||||
CreateCo cco = {
|
||||
.drv = drv,
|
||||
.filename = g_strdup(filename),
|
||||
.filename = filename,
|
||||
.opts = opts,
|
||||
.ret = NOT_DONE,
|
||||
.err = NULL,
|
||||
|
@ -559,8 +559,7 @@ int bdrv_create(BlockDriver *drv, const char* filename,
|
|||
|
||||
if (!drv->bdrv_co_create_opts) {
|
||||
error_setg(errp, "Driver '%s' does not support image creation", drv->format_name);
|
||||
ret = -ENOTSUP;
|
||||
goto out;
|
||||
return -ENOTSUP;
|
||||
}
|
||||
|
||||
if (qemu_in_coroutine()) {
|
||||
|
@ -583,8 +582,6 @@ int bdrv_create(BlockDriver *drv, const char* filename,
|
|||
}
|
||||
}
|
||||
|
||||
out:
|
||||
g_free(cco.filename);
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue