target/arm: Restrict the values of DCZID.BS under TCG
We can simplify our DC_ZVA if we recognize that the largest BS that we actually use in system mode is 64. Let us just assert that it fits within TARGET_PAGE_SIZE. For DC_GVA and STZGM, we want to be able to write whole bytes of tag memory, so assert that BS is >= 2 * TAG_GRANULE, or 32. Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20200626033144.790098-18-richard.henderson@linaro.org Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
parent
6439d67fc9
commit
a4157b8024
@ -1758,6 +1758,30 @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp)
|
||||
}
|
||||
#endif
|
||||
|
||||
if (tcg_enabled()) {
|
||||
int dcz_blocklen = 4 << cpu->dcz_blocksize;
|
||||
|
||||
/*
|
||||
* We only support DCZ blocklen that fits on one page.
|
||||
*
|
||||
* Architectually this is always true. However TARGET_PAGE_SIZE
|
||||
* is variable and, for compatibility with -machine virt-2.7,
|
||||
* is only 1KiB, as an artifact of legacy ARMv5 subpage support.
|
||||
* But even then, while the largest architectural DCZ blocklen
|
||||
* is 2KiB, no cpu actually uses such a large blocklen.
|
||||
*/
|
||||
assert(dcz_blocklen <= TARGET_PAGE_SIZE);
|
||||
|
||||
/*
|
||||
* We only support DCZ blocksize >= 2*TAG_GRANULE, which is to say
|
||||
* both nibbles of each byte storing tag data may be written at once.
|
||||
* Since TAG_GRANULE is 16, this means that blocklen must be >= 32.
|
||||
*/
|
||||
if (cpu_isar_feature(aa64_mte, cpu)) {
|
||||
assert(dcz_blocklen >= 2 * TAG_GRANULE);
|
||||
}
|
||||
}
|
||||
|
||||
qemu_init_vcpu(cs);
|
||||
cpu_reset(cs);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user