From a539dc8a2c76dc8f04585a265e07af6ebaa4b86a Mon Sep 17 00:00:00 2001 From: Andrew Deason Date: Tue, 26 Apr 2022 14:55:25 -0500 Subject: [PATCH] qga/commands-posix: Log all net stats failures MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit guest_get_network_stats can silently fail in a couple of ways. Add debug messages to these cases, so we're never completely silent on failure. Signed-off-by: Andrew Deason Reviewed-by: Marc-André Lureau Message-Id: <20220426195526.7699-5-adeason@sinenomine.net> --- qga/commands-posix.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index c1e994f3e6..ee997a58f2 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -2775,6 +2775,8 @@ static int guest_get_network_stats(const char *name, size_t n = 0; fp = fopen(devinfo, "r"); if (!fp) { + g_debug("failed to open network stats %s: %s", devinfo, + g_strerror(errno)); return -1; } name_len = strlen(name); @@ -2823,7 +2825,9 @@ static int guest_get_network_stats(const char *name, fclose(fp); g_free(line); g_debug("/proc/net/dev: Interface '%s' not found", name); -#endif /* CONFIG_LINUX */ +#else /* !CONFIG_LINUX */ + g_debug("Network stats reporting available only for Linux"); +#endif /* !CONFIG_LINUX */ return -1; }