From ab17b1fc75d9b961bf88a109b74069a383eba49f Mon Sep 17 00:00:00 2001 From: Cornelia Huck Date: Tue, 16 Oct 2018 13:51:54 +0200 Subject: [PATCH] s390x/vfio-ap: report correct error If ioctl(..., VFIO_DEVICE_RESET) fails, we want to report errno instead of ret (which is always -1 on error). Fixes Coverity issue CID 1396176. Reported-by: Peter Maydell Reviewed-by: Christian Borntraeger Reviewed-by: Thomas Huth Reviewed-by: Tony Krowiak Signed-off-by: Cornelia Huck --- hw/vfio/ap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 3962bb74e5..65de952f44 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -142,7 +142,7 @@ static void vfio_ap_reset(DeviceState *dev) ret = ioctl(vapdev->vdev.fd, VFIO_DEVICE_RESET); if (ret) { error_report("%s: failed to reset %s device: %s", __func__, - vapdev->vdev.name, strerror(ret)); + vapdev->vdev.name, strerror(errno)); } }