From aded9dfa74a83f8b235df1bd3a874e48e197c78e Mon Sep 17 00:00:00 2001 From: Cole Robinson Date: Tue, 9 Apr 2019 19:19:57 -0400 Subject: [PATCH] migration: savevm: fix error code with migration blockers The only caller that checks the error code is looking for != 0, so returning false is incorrect. Fixes: 5aaac467938 "migration: savevm: consult migration blockers" Signed-off-by: Cole Robinson Message-Id: Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/savevm.c b/migration/savevm.c index 587fec8ce2..81a9a2ef30 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2542,7 +2542,7 @@ int save_snapshot(const char *name, Error **errp) AioContext *aio_context; if (migration_is_blocked(errp)) { - return false; + return ret; } if (!replay_can_snapshot()) {