From af2d37de72ea67fddad0d51f5f81d7d7d54fd03a Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Sun, 4 Sep 2011 18:30:02 +0200 Subject: [PATCH] configure: Avoid duplicate flags when calling compile_prog This patch removes redundant shell code and cleans it a little bit. Shell macro compile_prog takes two arguments: local_cflags and local ldflags. $QEMU_CFLAGS is added automatically to the cflags, so there is no need to pass it as an argument. It is also unnecessary to pass -Werror twice. $flag is a compiler warning option, so it should be in local_cflags instead of local_ldflags. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index f808f48fd3..348f36ae18 100755 --- a/configure +++ b/configure @@ -1070,7 +1070,7 @@ cat > $TMPC << EOF int main(void) { return 0; } EOF for flag in $gcc_flags; do - if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then + if compile_prog "$flag -Werror" "" ; then QEMU_CFLAGS="$QEMU_CFLAGS $flag" fi done