OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

hw/block/pflash_cfi02: Unify the MemoryRegionOps

Browse Source 
The pflash_read()/pflash_write() can check the device endianess
via the pfl->be variable, so remove the 'int be' argument.

Since the big/little MemoryRegionOps are now identical, it is
pointless to declare them both. Unify them.

Signed-off-by: Stephen Checkoway <stephen.checkoway@oberlin.edu>
Message-Id: <20190426162624.55977-3-stephen.checkoway@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[PMD: Extracted from bigger patch to ease review]
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This commit is contained in:
Philippe Mathieu-Daudé 2019-05-01 18:15:56 +02:00
parent 06e8b8e3e1
commit aff498cf30
1 changed files with 15 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
hw/block/pflash_cfi02.c
View File

@ -177,11 +177,11 @@ static uint64_t pflash_data_read(PFlashCFI02 *pfl, hwaddr offset,
return ret; return ret;
} }
static uint32_t pflash_read(PFlashCFI02 *pfl, hwaddr offset, static uint64_t pflash_read(void *opaque, hwaddr offset, unsigned int width)
int width, int be)
{ {
PFlashCFI02 *pfl = opaque;
hwaddr boff; hwaddr boff;
uint32_t ret; uint64_t ret;
ret = -1; ret = -1;
/* Lazy reset to ROMD mode after a certain amount of read accesses */ /* Lazy reset to ROMD mode after a certain amount of read accesses */
@ -228,14 +228,14 @@ static uint32_t pflash_read(PFlashCFI02 *pfl, hwaddr offset,
default: default:
ret = pflash_data_read(pfl, offset, width); ret = pflash_data_read(pfl, offset, width);
} }
DPRINTF("%s: ID " TARGET_FMT_plx " %" PRIx32 "\n", __func__, boff, ret); DPRINTF("%s: ID " TARGET_FMT_plx " %" PRIx64 "\n", __func__, boff, ret);
break; break;
case 0xA0: case 0xA0:
case 0x10: case 0x10:
case 0x30: case 0x30:
/* Status register read */ /* Status register read */
ret = pfl->status; ret = pfl->status;
DPRINTF("%s: status %" PRIx32 "\n", __func__, ret); DPRINTF("%s: status %" PRIx64 "\n", __func__, ret);
toggle_dq6(pfl); toggle_dq6(pfl);
break; break;
case 0x98: case 0x98:
@ -253,8 +253,7 @@ static uint32_t pflash_read(PFlashCFI02 *pfl, hwaddr offset,
} }
/* update flash content on disk */ /* update flash content on disk */
static void pflash_update(PFlashCFI02 *pfl, int offset, static void pflash_update(PFlashCFI02 *pfl, int offset, int size)
int size)
{ {
int offset_end; int offset_end;
if (pfl->blk) { if (pfl->blk) {
@ -267,9 +266,10 @@ static void pflash_update(PFlashCFI02 *pfl, int offset,
} }
} }
static void pflash_write(PFlashCFI02 *pfl, hwaddr offset, static void pflash_write(void *opaque, hwaddr offset, uint64_t value,
uint32_t value, int width, int be) unsigned int width)
{ {
PFlashCFI02 *pfl = opaque;
hwaddr boff; hwaddr boff;
uint8_t *p; uint8_t *p;
uint8_t cmd; uint8_t cmd;
@ -477,39 +477,9 @@ static void pflash_write(PFlashCFI02 *pfl, hwaddr offset,
pfl->cmd = 0; pfl->cmd = 0;
} }
static uint64_t pflash_be_readfn(void *opaque, hwaddr addr, unsigned size) static const MemoryRegionOps pflash_cfi02_ops = {
{ .read = pflash_read,
return pflash_read(opaque, addr, size, 1); .write = pflash_write,
}
static void pflash_be_writefn(void *opaque, hwaddr addr,
uint64_t value, unsigned size)
{
pflash_write(opaque, addr, value, size, 1);
}
static uint64_t pflash_le_readfn(void *opaque, hwaddr addr, unsigned size)
{
return pflash_read(opaque, addr, size, 0);
}
static void pflash_le_writefn(void *opaque, hwaddr addr,
uint64_t value, unsigned size)
{
pflash_write(opaque, addr, value, size, 0);
}
static const MemoryRegionOps pflash_cfi02_ops_be = {
.read = pflash_be_readfn,
.write = pflash_be_writefn,
.valid.min_access_size = 1,
.valid.max_access_size = 4,
.endianness = DEVICE_NATIVE_ENDIAN,
};
static const MemoryRegionOps pflash_cfi02_ops_le = {
.read = pflash_le_readfn,
.write = pflash_le_writefn,
.valid.min_access_size = 1, .valid.min_access_size = 1,
.valid.max_access_size = 4, .valid.max_access_size = 4,
.endianness = DEVICE_NATIVE_ENDIAN, .endianness = DEVICE_NATIVE_ENDIAN,
@ -537,9 +507,9 @@ static void pflash_cfi02_realize(DeviceState *dev, Error **errp)
chip_len = pfl->sector_len * pfl->nb_blocs; chip_len = pfl->sector_len * pfl->nb_blocs;
memory_region_init_rom_device(&pfl->orig_mem, OBJECT(pfl), pfl->be ? memory_region_init_rom_device(&pfl->orig_mem, OBJECT(pfl),
&pflash_cfi02_ops_be : &pflash_cfi02_ops_le, &pflash_cfi02_ops, pfl, pfl->name,
pfl, pfl->name, chip_len, &local_err); chip_len, &local_err);
if (local_err) { if (local_err) {
error_propagate(errp, local_err); error_propagate(errp, local_err);
return; return;