OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

blockdev: Don't use qerror_report() in do_drive_del()

Browse Source 
qerror_report() is a transitional interface to help with converting
existing HMP commands to QMP.  It should not be used elsewhere.

do_drive_del() is an HMP command that won't be converted to QMP (we'll
create a new QMP command instead).  It uses both qerror_report() and
error_report().  Convert the former to the latter.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Markus Armbruster 2014-05-16 11:00:09 +02:00 committed by Stefan Hajnoczi
parent e8817e7b0e
commit b1422f2040
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
blockdev.c
View File

@ -34,7 +34,6 @@
#include "hw/block/block.h" #include "hw/block/block.h"
#include "block/blockjob.h" #include "block/blockjob.h"
#include "monitor/monitor.h" #include "monitor/monitor.h"
#include "qapi/qmp/qerror.h"
#include "qemu/option.h" #include "qemu/option.h"
#include "qemu/config-file.h" #include "qemu/config-file.h"
#include "qapi/qmp/types.h" #include "qapi/qmp/types.h"
@ -1763,7 +1762,7 @@ int do_drive_del(Monitor *mon, const QDict *qdict, QObject **ret_data)
bs = bdrv_find(id); bs = bdrv_find(id);
if (!bs) { if (!bs) {
qerror_report(QERR_DEVICE_NOT_FOUND, id); error_report("Device '%s' not found", id);
return -1; return -1;
} }
if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_DRIVE_DEL, &local_err)) { if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_DRIVE_DEL, &local_err)) {