OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

s390x/sclpconsole-lm: truncate input if line is too long

Browse Source 
As the SCLP line mode console input length is limited by the available
SCCB buffer space, it might lock up if the input does not fit into the
buffer.

With this patch, characters that don't fit are 'eaten' up to the next
CR/LF and the input line is sent truncated to the guest.

Signed-off-by: Heinz Graalfs <graalfs@linux.vnet.ibm.com>
Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
This commit is contained in:
Heinz Graalfs 2014-10-29 08:58:05 +00:00 committed by Cornelia Huck
parent f0d4dc18ce
commit b3191432cf
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hw/char/sclpconsole-lm.c
View File

@ -52,7 +52,8 @@ typedef struct SCLPConsoleLM {
* event_pending is set when a newline character is encountered * event_pending is set when a newline character is encountered
* *
* The maximum command line length is limited by the maximum * The maximum command line length is limited by the maximum
* space available in an SCCB * space available in an SCCB. Line mode console input is sent
* truncated to the guest in case it doesn't fit into the SCCB.
*/ */
static int chr_can_read(void *opaque) static int chr_can_read(void *opaque)
@ -61,10 +62,8 @@ static int chr_can_read(void *opaque)
if (scon->event.event_pending) { if (scon->event.event_pending) {
return 0; return 0;
} else if (SIZE_CONSOLE_BUFFER - scon->length) {
return 1;
} }
return 0; return 1;
} }
static void chr_read(void *opaque, const uint8_t *buf, int size) static void chr_read(void *opaque, const uint8_t *buf, int size)
@ -78,6 +77,10 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
sclp_service_interrupt(0); sclp_service_interrupt(0);
return; return;
} }
if (scon->length == SIZE_CONSOLE_BUFFER) {
/* Eat the character, but still process CR and LF. */
return;
}
scon->buf[scon->length] = *buf; scon->buf[scon->length] = *buf;
scon->length += 1; scon->length += 1;
if (scon->echo) { if (scon->echo) {