OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

crypto: assert that qcrypto_hash_digest_len is in range

Browse Source 
Otherwise unintended results could happen.  For example,
Coverity reports a division by zero in qcrypto_afsplit_hash.
While this cannot really happen, it shows that the contract
of qcrypto_hash_digest_len can be improved.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Paolo Bonzini 2016-05-20 11:09:54 +02:00 committed by Daniel P. Berrange
parent e7ed11f083
commit b35c1f3361
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/hash.c
View File

@ -36,9 +36,7 @@ static size_t qcrypto_hash_alg_size[QCRYPTO_HASH_ALG__MAX] = {
size_t qcrypto_hash_digest_len(QCryptoHashAlgorithm alg) size_t qcrypto_hash_digest_len(QCryptoHashAlgorithm alg)
{ {
if (alg >= G_N_ELEMENTS(qcrypto_hash_alg_size)) { assert(alg < G_N_ELEMENTS(qcrypto_hash_alg_size));
return 0;
}
return qcrypto_hash_alg_size[alg]; return qcrypto_hash_alg_size[alg];
} }