OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

configure: Avoid use of 'local' as it is non-POSIX

Browse Source 
We use the non-POSIX 'local' keyword in just two places in configure;
rewrite to avoid it.

In do_compiler(), just drop the 'local' keyword.  The variable
'compiler' is only used elsewhere in the do_compiler_werror()
function, which already uses the variable as a normal non-local one.

In probe_target_compiler(), $try and $t are both local; make them
normal variables and use a more obviously distinct variable name
for $t.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220825150703.4074125-8-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2022-08-25 16:07:03 +01:00
parent 563661c056
commit b3b5472db0
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
configure vendored
View File

@ -110,7 +110,7 @@ error_exit() {
do_compiler() { do_compiler() {
# Run the compiler, capturing its output to the log. First argument # Run the compiler, capturing its output to the log. First argument
# is compiler binary to execute. # is compiler binary to execute.
local compiler="$1" compiler="$1"
shift shift
if test -n "$BASH_VERSION"; then eval ' if test -n "$BASH_VERSION"; then eval '
echo >>config.log " echo >>config.log "
@ -2065,7 +2065,6 @@ probe_target_compiler() {
: ${container_cross_strip:=${container_cross_prefix}strip} : ${container_cross_strip:=${container_cross_prefix}strip}
done done
local t try
try=cross try=cross
case "$target_arch:$cpu" in case "$target_arch:$cpu" in
aarch64_be:aarch64 | \ aarch64_be:aarch64 | \
@ -2078,8 +2077,8 @@ probe_target_compiler() {
try='native cross' ;; try='native cross' ;;
esac esac
eval "target_cflags=\${cross_cc_cflags_$target_arch}" eval "target_cflags=\${cross_cc_cflags_$target_arch}"
for t in $try; do for thistry in $try; do
case $t in case $thistry in
native) native)
target_cc=$cc target_cc=$cc
target_ccas=$ccas target_ccas=$ccas