OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

TCG: fix negative frame offset calculations

Browse Source 
size_t is unsigned, so the frame offset calculations can be incorrect for
negative offsets.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
This commit is contained in:
Blue Swirl 2011-05-14 14:03:22 +00:00
parent 614f104dfd
commit b591dc59bc
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tcg/tcg.c
View File

@ -1439,13 +1439,17 @@ static void temp_allocate_frame(TCGContext *s, int temp)
{ {
TCGTemp *ts; TCGTemp *ts;
ts = &s->temps[temp]; ts = &s->temps[temp];
s->current_frame_offset = (s->current_frame_offset + sizeof(tcg_target_long) - 1) & ~(sizeof(tcg_target_long) - 1); s->current_frame_offset = (s->current_frame_offset +
if (s->current_frame_offset + sizeof(tcg_target_long) > s->frame_end) (tcg_target_long)sizeof(tcg_target_long) - 1) &
~(sizeof(tcg_target_long) - 1);
if (s->current_frame_offset + (tcg_target_long)sizeof(tcg_target_long) >
s->frame_end) {
tcg_abort(); tcg_abort();
}
ts->mem_offset = s->current_frame_offset; ts->mem_offset = s->current_frame_offset;
ts->mem_reg = s->frame_reg; ts->mem_reg = s->frame_reg;
ts->mem_allocated = 1; ts->mem_allocated = 1;
s->current_frame_offset += sizeof(tcg_target_long); s->current_frame_offset += (tcg_target_long)sizeof(tcg_target_long);
} }
/* free register 'reg' by spilling the corresponding temporary if necessary */ /* free register 'reg' by spilling the corresponding temporary if necessary */