From b71706d122838d9656e1a6dae80e22401babdf37 Mon Sep 17 00:00:00 2001 From: Jeff Cody Date: Thu, 15 Mar 2012 14:26:18 -0400 Subject: [PATCH] qemu-ga: for w32, fix leaked handle ov.hEvent in ga_channel_write() In the function ga_channel_write(), the handle ov.hEvent is created by the call to CreateEvent(). However, the handle is not closed prior to the function return. This patch closes the handle before the return of the function. Kudos to Paolo Bonzini for spotting this bug. Signed-off-by: Jeff Cody Acked-by: Michael Roth Signed-off-by: Stefan Hajnoczi --- qga/channel-win32.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 190251bb57..16bf44a376 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -259,6 +259,10 @@ static GIOStatus ga_channel_write(GAChannel *c, const char *buf, size_t size, *count = written; } + if (ov.hEvent) { + CloseHandle(ov.hEvent); + ov.hEvent = NULL; + } return status; }