OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

net/socket: fix coverity issue

Browse Source 
This fixes coverity issue CID1005339.

Make sure that saddr is not used uninitialized if the
mcast parameter is NULL.

Cc: qemu-stable@nongnu.org
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Jens Freimann 2017-11-06 15:05:46 +01:00 committed by Jason Wang
parent 5e89dc0113
commit bb160b571f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/socket.c
View File

@ -373,7 +373,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer,
net_socket_read_poll(s, true); net_socket_read_poll(s, true);
/* mcast: save bound address as dst */ /* mcast: save bound address as dst */
if (is_connected) { if (is_connected && mcast != NULL) {
s->dgram_dst = saddr; s->dgram_dst = saddr;
snprintf(nc->info_str, sizeof(nc->info_str), snprintf(nc->info_str, sizeof(nc->info_str),
"socket: fd=%d (cloned mcast=%s:%d)", "socket: fd=%d (cloned mcast=%s:%d)",