replay: introduce mutex to protect the replay log

This mutex will protect read/write operations for replay log.
Using mutex is necessary because most of the events consist of
several fields stored in the log. The mutex will help to avoid races.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Message-Id: <20150917162348.8676.8628.stgit@PASHA-ISP.def.inno>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Pavel Dovgalyuk 2015-09-17 19:23:48 +03:00 committed by Paolo Bonzini
parent c92079f45f
commit c16861ef1b
2 changed files with 34 additions and 0 deletions

View File

@ -17,6 +17,13 @@
unsigned int replay_data_kind = -1;
static unsigned int replay_has_unread_data;
/* Mutex to protect reading and writing events to the log.
replay_data_kind and replay_has_unread_data are also protected
by this mutex.
It also protects replay events queue which stores events to be
written or read to the log. */
static QemuMutex lock;
/* File for replay writing */
FILE *replay_file;
@ -153,3 +160,23 @@ void replay_finish_event(void)
replay_has_unread_data = 0;
replay_fetch_data_kind();
}
void replay_mutex_init(void)
{
qemu_mutex_init(&lock);
}
void replay_mutex_destroy(void)
{
qemu_mutex_destroy(&lock);
}
void replay_mutex_lock(void)
{
qemu_mutex_lock(&lock);
}
void replay_mutex_unlock(void)
{
qemu_mutex_unlock(&lock);
}

View File

@ -33,6 +33,13 @@ int64_t replay_get_qword(void);
void replay_get_array(uint8_t *buf, size_t *size);
void replay_get_array_alloc(uint8_t **buf, size_t *size);
/* Mutex functions for protecting replay log file */
void replay_mutex_init(void);
void replay_mutex_destroy(void);
void replay_mutex_lock(void);
void replay_mutex_unlock(void);
/*! Checks error status of the file. */
void replay_check_error(void);