OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

tests/unit/test-qmp-event: Drop superfluous mutex

Browse Source 
Mutex @test_event_lock is held from fixture setup to teardown,
protecting global variable @test_event_data.  But tests always run one
after the other, so this is superfluous.  It also confuses Coverity.
Drop the mutex.

Fixes: CID 1527425
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20231122072456.2518816-2-armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Markus Armbruster 2023-11-22 08:24:54 +01:00 committed by Thomas Huth
parent 71dc6ca2a8
commit c363764a60
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unit/test-qmp-event.c
View File

@ -30,7 +30,6 @@ typedef struct TestEventData {
} TestEventData; } TestEventData;
TestEventData *test_event_data; TestEventData *test_event_data;
static GMutex test_event_lock;
void test_qapi_event_emit(test_QAPIEvent event, QDict *d) void test_qapi_event_emit(test_QAPIEvent event, QDict *d)
{ {
@ -59,9 +58,6 @@ void test_qapi_event_emit(test_QAPIEvent event, QDict *d)
static void event_prepare(TestEventData *data, static void event_prepare(TestEventData *data,
const void *unused) const void *unused)
{ {
/* Global variable test_event_data was used to pass the expectation, so
test cases can't be executed at same time. */
g_mutex_lock(&test_event_lock);
test_event_data = data; test_event_data = data;
} }
@ -69,7 +65,6 @@ static void event_teardown(TestEventData *data,
const void *unused) const void *unused)
{ {
test_event_data = NULL; test_event_data = NULL;
g_mutex_unlock(&test_event_lock);
} }
static void event_test_add(const char *testpath, static void event_test_add(const char *testpath,