From c370f09dba0f0d92e0e8127e9e444f58e9332448 Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Thu, 13 Oct 2011 11:36:40 -0300 Subject: [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic qemu_savevm_state() has some logic to stop the VM and to (or not to) resume it. But this seems to be a big noop, as qemu_savevm_state() is only called by do_savevm() when the VM is already stopped. So, let's drop qemu_savevm_state()'s stop VM logic. Reviewed-by: Michael Roth Reviewed-by: Kevin Wolf Reviewed-by: Juan Quintela Signed-off-by: Luiz Capitulino --- savevm.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/savevm.c b/savevm.c index bf4d0e76c3..abb4a60643 100644 --- a/savevm.c +++ b/savevm.c @@ -1599,12 +1599,8 @@ void qemu_savevm_state_cancel(Monitor *mon, QEMUFile *f) static int qemu_savevm_state(Monitor *mon, QEMUFile *f) { - int saved_vm_running; int ret; - saved_vm_running = runstate_is_running(); - vm_stop(RUN_STATE_SAVE_VM); - if (qemu_savevm_state_blocked(mon)) { ret = -EINVAL; goto out; @@ -1626,9 +1622,6 @@ out: if (qemu_file_has_error(f)) ret = -EIO; - if (!ret && saved_vm_running) - vm_start(); - return ret; }