OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

Revert "tests: qmp-test: verify command batching" 

This reverts commit 91ad45061a.

Enabling OOB caused several iotests failures; due to the imminent
2.12 release, the safest action is to disable OOB, but first we
have to revert tests that rely on OOB.

Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20180323140821.28957-4-peterx@redhat.com>
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
[eblake: reorder commits, enhance commit message]
Signed-off-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Peter Xu 2018-03-23 22:08:20 +08:00 committed by Eric Blake
parent 4fd78ad793
commit cc797607c0
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/qmp-test.c
View File

@ -82,7 +82,6 @@ static void test_qmp_protocol(void)
QTestState *qts;
const QListEntry *entry;
QString *qstr;
int i;
qts = qtest_init_without_qmp_handshake(common_args);
@ -140,27 +139,6 @@ static void test_qmp_protocol(void)
g_assert_cmpint(qdict_get_int(resp, "id"), ==, 2);
QDECREF(resp);
/*
* Test command batching. In current test OOB is not enabled, we
* should be able to run as many commands in batch as we like.
* Using 16 (>8, which is OOB queue length) to make sure OOB won't
* break existing clients. Note: this test does not control the
* scheduling of QEMU's QMP command processing threads so it may
* not really trigger batching inside QEMU. This is just a
* best-effort test.
*/
for (i = 0; i < 16; i++) {
qtest_async_qmp(qts, "{ 'execute': 'query-version' }");
}
/* Verify the replies to make sure no command is dropped. */
for (i = 0; i < 16; i++) {
resp = qtest_qmp_receive(qts);
/* It should never be dropped. Each of them should be a reply. */
g_assert(qdict_haskey(resp, "return"));
g_assert(!qdict_haskey(resp, "event"));
QDECREF(resp);
}
qtest_quit(qts);
}