OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

readline: Add missing GCC_FMT_ATTR 

This fixes a compiler warning with -Werror=missing-format-attribute
and allows improved compiler checks for variable argument lists.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Stefan Weil 2014-01-25 18:18:23 +01:00 committed by Michael Tokarev
parent c6830cdb2c
commit d5d1507b34
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/qemu/readline.h
View File

@ -5,7 +5,8 @@
#define READLINE_MAX_CMDS 64 #define READLINE_MAX_CMDS 64
#define READLINE_MAX_COMPLETIONS 256 #define READLINE_MAX_COMPLETIONS 256
typedef void ReadLinePrintfFunc(void *opaque, const char *fmt, ...); typedef void GCC_FMT_ATTR(2, 3) ReadLinePrintfFunc(void *opaque,
const char *fmt, ...);
typedef void ReadLineFlushFunc(void *opaque); typedef void ReadLineFlushFunc(void *opaque);
typedef void ReadLineFunc(void *opaque, const char *str, typedef void ReadLineFunc(void *opaque, const char *str,
void *readline_opaque); void *readline_opaque);

3
monitor.c
View File

@ -4888,7 +4888,8 @@ static void sortcmdlist(void)
/* These functions just adapt the readline interface in a typesafe way. We /* These functions just adapt the readline interface in a typesafe way. We
* could cast function pointers but that discards compiler checks. * could cast function pointers but that discards compiler checks.
*/ */
static void monitor_readline_printf(void *opaque, const char *fmt, ...) static void GCC_FMT_ATTR(2, 3) monitor_readline_printf(void *opaque,
const char *fmt, ...)
{ {
va_list ap; va_list ap;
va_start(ap, fmt); va_start(ap, fmt);

3
qemu-io.c
View File

@ -219,7 +219,8 @@ static char *get_prompt(void)
return prompt; return prompt;
} }
static void readline_printf_func(void *opaque, const char *fmt, ...) static void GCC_FMT_ATTR(2, 3) readline_printf_func(void *opaque,
const char *fmt, ...)
{ {
va_list ap; va_list ap;
va_start(ap, fmt); va_start(ap, fmt);