OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

pc-bios/s390-ccw: Clean up harmless misuse of isdigit() 

atoui() and get_index() pass char values to isdigit().  With a
standard isdigit(), we'd get undefined behavior when the value is
negative.  Can't happen as char is unsigned on s390x.  Even if it
ould, we're actually using isdigit() from pc-bios/s390-ccw/libc.h
here, which works fine for negative values.  Clean up anyway, just
to avoid setting a bad example.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190418145355.21100-6-armbru@redhat.com>
[thuth: updated the commit message]
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Markus Armbruster 2019-04-18 16:53:54 +02:00 committed by Thomas Huth
parent a6f6d24757
commit d796588ba1
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pc-bios/s390-ccw/libc.c
View File

@ -38,7 +38,7 @@ uint64_t atoui(const char *str)
}
while (*str) {
if (!isdigit(*str)) {
if (!isdigit(*(unsigned char *)str)) {
break;
}
val = val * 10 + *str - '0';

2
pc-bios/s390-ccw/menu.c
View File

@ -134,7 +134,7 @@ static int get_index(void)
/* Check for erroneous input */
for (i = 0; i < len; i++) {
if (!isdigit(buf[i])) {
if (!isdigit((unsigned char)buf[i])) {
return -1;
}
}