monitor: more comments on lock-free elements
Add some explicit comments for both Readline and cpu_set/cpu_get helpers that they do not need the mon_lock protection. Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Peter Xu <peterx@redhat.com> Message-Id: <20180608035511.7439-4-peterx@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
parent
9409fc05fe
commit
d9f252809e
11
monitor.c
11
monitor.c
|
@ -206,7 +206,15 @@ struct Monitor {
|
||||||
int suspend_cnt; /* Needs to be accessed atomically */
|
int suspend_cnt; /* Needs to be accessed atomically */
|
||||||
bool skip_flush;
|
bool skip_flush;
|
||||||
bool use_io_thr;
|
bool use_io_thr;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* State used only in the thread "owning" the monitor.
|
||||||
|
* If @use_io_thr, this is mon_global.mon_iothread.
|
||||||
|
* Else, it's the main thread.
|
||||||
|
* These members can be safely accessed without locks.
|
||||||
|
*/
|
||||||
ReadLineState *rs;
|
ReadLineState *rs;
|
||||||
|
|
||||||
MonitorQMP qmp;
|
MonitorQMP qmp;
|
||||||
gchar *mon_cpu_path;
|
gchar *mon_cpu_path;
|
||||||
BlockCompletionFunc *password_completion_cb;
|
BlockCompletionFunc *password_completion_cb;
|
||||||
|
@ -1311,7 +1319,7 @@ void qmp_qmp_capabilities(bool has_enable, QMPCapabilityList *enable,
|
||||||
cur_mon->qmp.commands = &qmp_commands;
|
cur_mon->qmp.commands = &qmp_commands;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* set the current CPU defined by the user */
|
/* Set the current CPU defined by the user. Callers must hold BQL. */
|
||||||
int monitor_set_cpu(int cpu_index)
|
int monitor_set_cpu(int cpu_index)
|
||||||
{
|
{
|
||||||
CPUState *cpu;
|
CPUState *cpu;
|
||||||
|
@ -1325,6 +1333,7 @@ int monitor_set_cpu(int cpu_index)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Callers must hold BQL. */
|
||||||
static CPUState *mon_get_cpu_sync(bool synchronize)
|
static CPUState *mon_get_cpu_sync(bool synchronize)
|
||||||
{
|
{
|
||||||
CPUState *cpu;
|
CPUState *cpu;
|
||||||
|
|
Loading…
Reference in New Issue