tests/tcg: ensure system-mode gdb tests start stopped
Without -S we run into potential races with tests starting before the gdbstub attaches. We don't need to worry about user-mode as enabling the gdbstub implies we wait for the initial connection. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20230810153640.1879717-7-alex.bennee@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
parent
6a2c23ddeb
commit
dad1036f43
@ -69,13 +69,10 @@ if __name__ == '__main__':
|
||||
|
||||
# Launch QEMU with binary
|
||||
if "system" in args.qemu:
|
||||
cmd = "%s %s %s -gdb unix:path=%s,server=on" % (args.qemu,
|
||||
args.qargs,
|
||||
args.binary,
|
||||
socket_name)
|
||||
cmd = f'{args.qemu} {args.qargs} {args.binary}' \
|
||||
f' -S -gdb unix:path={socket_name},server=on'
|
||||
else:
|
||||
cmd = "%s %s -g %s %s" % (args.qemu, args.qargs, socket_name,
|
||||
args.binary)
|
||||
cmd = f'{args.qemu} {args.qargs} -g {socket_name} {args.binary}'
|
||||
|
||||
log(output, "QEMU CMD: %s" % (cmd))
|
||||
inferior = subprocess.Popen(shlex.split(cmd))
|
||||
|
Loading…
Reference in New Issue
Block a user