OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

hw/arm/mps2-tz: Fix MPC setting for AN524 SRAM block

Browse Source 
The AN524 has three MPCs: one for the BRAM, one for the QSPI flash,
and one for the DDR.  We incorrectly set the .mpc field in the
RAMInfo struct for the SRAM block to 1, giving it the same MPC we are
using for the QSPI.  The effect of this was that the QSPI didn't get
mapped into the system address space at all, via an MPC or otherwise,
and guest programs which tried to read from the QSPI would get a bus
error.  Correct the SRAM RAMInfo to indicate that it does not have an
associated MPC.

Fixes: 25ff112a8c ("hw/arm/mps2-tz: Add new mps3-an524 board")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20210409150527.15053-2-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2021-04-09 16:05:26 +01:00
parent c1e90def01
commit db2fc83aa4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/arm/mps2-tz.c
View File

@ -238,7 +238,7 @@ static const RAMInfo an524_raminfo[] = { {
.name = "sram", .name = "sram",
.base = 0x20000000, .base = 0x20000000,
.size = 32 * 4 * KiB, .size = 32 * 4 * KiB,
.mpc = 1, .mpc = -1,
.mrindex = 1, .mrindex = 1,
}, { }, {
/* We don't model QSPI flash yet; for now expose it as simple ROM */ /* We don't model QSPI flash yet; for now expose it as simple ROM */