OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

target/xtensa: handle unknown registers in gdbstub

Browse Source 
Xtensa cores may have registers of types/sizes not supported by the
gdbstub accessors. Ignore writes to such registers and return zero on
read, but always return correct register size, so that gdb on the other
side is able to access all registers in the packet holding unsupported
registers in the middle. This fixes gdb interaction with cores that have
vector/custom TIE registers.

Cc: qemu-stable@nongnu.org
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
This commit is contained in:
Max Filippov 2017-06-03 02:11:13 -07:00
parent 8128b3e079
commit dd7b952b79
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
target/xtensa/gdbstub.c
View File

@ -58,7 +58,10 @@ int xtensa_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)
case 8: case 8:
return gdb_get_reg64(mem_buf, float64_val(env->fregs[i].f64)); return gdb_get_reg64(mem_buf, float64_val(env->fregs[i].f64));
default: default:
return 0; qemu_log_mask(LOG_UNIMP, "%s from reg %d of unsupported size %d\n",
__func__, n, reg->size);
memset(mem_buf, 0, reg->size);
return reg->size;
} }
case 8: /*a*/ case 8: /*a*/
@ -67,6 +70,8 @@ int xtensa_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)
default: default:
qemu_log_mask(LOG_UNIMP, "%s from reg %d of unsupported type %d\n", qemu_log_mask(LOG_UNIMP, "%s from reg %d of unsupported type %d\n",
__func__, n, reg->type); __func__, n, reg->type);
memset(mem_buf, 0, reg->size);
return reg->size;
return 0; return 0;
} }
} }
@ -111,7 +116,9 @@ int xtensa_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
env->fregs[reg->targno & 0x0f].f64 = make_float64(tmp); env->fregs[reg->targno & 0x0f].f64 = make_float64(tmp);
return 8; return 8;
default: default:
return 0; qemu_log_mask(LOG_UNIMP, "%s to reg %d of unsupported size %d\n",
__func__, n, reg->size);
return reg->size;
} }
case 8: /*a*/ case 8: /*a*/
@ -121,7 +128,7 @@ int xtensa_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
default: default:
qemu_log_mask(LOG_UNIMP, "%s to reg %d of unsupported type %d\n", qemu_log_mask(LOG_UNIMP, "%s to reg %d of unsupported type %d\n",
__func__, n, reg->type); __func__, n, reg->type);
return 0; return reg->size;
} }
return 4; return 4;