OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

migration/rdma: Convert qemu_rdma_reg_whole_ram_blocks() to Error

Browse Source 
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because reporting is the caller's
job.  When the caller does, the error is reported twice.  When it
doesn't (because it recovered from the error), there is no error to
report, i.e. the report is bogus.

qemu_rdma_exchange_send() violates this principle: it calls
error_report() via callback qemu_rdma_reg_whole_ram_blocks().  I
elected not to investigate how callers handle the error, i.e. precise
impact is not known.

Clean this up by converting the callback to Error.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230928132019.2544702-39-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2023-09-28 15:20:04 +02:00 committed by Juan Quintela
parent 3765ec1f43
commit de1aa35f8d
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
migration/rdma.c
View File

@ -518,7 +518,8 @@ static void network_to_result(RDMARegisterResult *result)
static int qemu_rdma_exchange_send(RDMAContext *rdma, RDMAControlHeader *head, static int qemu_rdma_exchange_send(RDMAContext *rdma, RDMAControlHeader *head,
uint8_t *data, RDMAControlHeader *resp, uint8_t *data, RDMAControlHeader *resp,
int *resp_idx, int *resp_idx,
int (*callback)(RDMAContext *rdma), int (*callback)(RDMAContext *rdma,
Error **errp),
Error **errp); Error **errp);
static inline uint64_t ram_chunk_index(const uint8_t *start, static inline uint64_t ram_chunk_index(const uint8_t *start,
@ -1177,7 +1178,7 @@ static void qemu_rdma_advise_prefetch_mr(struct ibv_pd *pd, uint64_t addr,
#endif #endif
} }
static int qemu_rdma_reg_whole_ram_blocks(RDMAContext *rdma) static int qemu_rdma_reg_whole_ram_blocks(RDMAContext *rdma, Error **errp)
{ {
int i; int i;
RDMALocalBlocks *local = &rdma->local_ram_blocks; RDMALocalBlocks *local = &rdma->local_ram_blocks;
@ -1217,16 +1218,16 @@ static int qemu_rdma_reg_whole_ram_blocks(RDMAContext *rdma)
} }
if (!local->block[i].mr) { if (!local->block[i].mr) {
perror("Failed to register local dest ram block!"); error_setg_errno(errp, errno,
break; "Failed to register local dest ram block!");
goto err;
} }
rdma->total_registrations++; rdma->total_registrations++;
} }
if (i >= local->nb_blocks) {
return 0; return 0;
}
err:
for (i--; i >= 0; i--) { for (i--; i >= 0; i--) {
ibv_dereg_mr(local->block[i].mr); ibv_dereg_mr(local->block[i].mr);
local->block[i].mr = NULL; local->block[i].mr = NULL;
@ -1899,7 +1900,8 @@ static void qemu_rdma_move_header(RDMAContext *rdma, int idx,
static int qemu_rdma_exchange_send(RDMAContext *rdma, RDMAControlHeader *head, static int qemu_rdma_exchange_send(RDMAContext *rdma, RDMAControlHeader *head,
uint8_t *data, RDMAControlHeader *resp, uint8_t *data, RDMAControlHeader *resp,
int *resp_idx, int *resp_idx,
int (*callback)(RDMAContext *rdma), int (*callback)(RDMAContext *rdma,
Error **errp),
Error **errp) Error **errp)
{ {
int ret; int ret;
@ -1956,9 +1958,8 @@ static int qemu_rdma_exchange_send(RDMAContext *rdma, RDMAControlHeader *head,
if (resp) { if (resp) {
if (callback) { if (callback) {
trace_qemu_rdma_exchange_send_issue_callback(); trace_qemu_rdma_exchange_send_issue_callback();
ret = callback(rdma); ret = callback(rdma, errp);
if (ret < 0) { if (ret < 0) {
error_setg(errp, "FIXME temporary error message");
return -1; return -1;
} }
} }
@ -3671,10 +3672,9 @@ static int qemu_rdma_registration_handle(QEMUFile *f)
} }
if (rdma->pin_all) { if (rdma->pin_all) {
ret = qemu_rdma_reg_whole_ram_blocks(rdma); ret = qemu_rdma_reg_whole_ram_blocks(rdma, &err);
if (ret < 0) { if (ret < 0) {
error_report("rdma migration: error dest " error_report_err(err);
"registering ram blocks");
goto err; goto err;
} }
} }