target-mips: fix compiler warnings (clang 5)
static code analyzer complain: target/mips/helper.c:453:5: warning: Function call argument is an uninitialized value qemu_log_mask(CPU_LOG_MMU, ^~~~~~~~~~~~~~~~~~~~~~~~~~ 'physical' and 'prot' are uninitialized if 'ret' is not TLBRET_MATCH. Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Yongbok Kim <yongbok.kim@imgtec.com> Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
This commit is contained in:
parent
bedf13ecab
commit
def74c0cf0
|
@ -450,10 +450,18 @@ int mips_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int rw,
|
||||||
access_type = ACCESS_INT;
|
access_type = ACCESS_INT;
|
||||||
ret = get_physical_address(env, &physical, &prot,
|
ret = get_physical_address(env, &physical, &prot,
|
||||||
address, rw, access_type);
|
address, rw, access_type);
|
||||||
qemu_log_mask(CPU_LOG_MMU,
|
switch (ret) {
|
||||||
"%s address=%" VADDR_PRIx " ret %d physical " TARGET_FMT_plx
|
case TLBRET_MATCH:
|
||||||
" prot %d\n",
|
qemu_log_mask(CPU_LOG_MMU,
|
||||||
__func__, address, ret, physical, prot);
|
"%s address=%" VADDR_PRIx " physical " TARGET_FMT_plx
|
||||||
|
" prot %d\n", __func__, address, physical, prot);
|
||||||
|
break;
|
||||||
|
default:
|
||||||
|
qemu_log_mask(CPU_LOG_MMU,
|
||||||
|
"%s address=%" VADDR_PRIx " ret %d\n", __func__, address,
|
||||||
|
ret);
|
||||||
|
break;
|
||||||
|
}
|
||||||
if (ret == TLBRET_MATCH) {
|
if (ret == TLBRET_MATCH) {
|
||||||
tlb_set_page(cs, address & TARGET_PAGE_MASK,
|
tlb_set_page(cs, address & TARGET_PAGE_MASK,
|
||||||
physical & TARGET_PAGE_MASK, prot | PAGE_EXEC,
|
physical & TARGET_PAGE_MASK, prot | PAGE_EXEC,
|
||||||
|
|
Loading…
Reference in New Issue