OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

nbd: Don't mishandle unaligned client requests

Browse Source 
The NBD protocol does not (yet) force any alignment constraints
on clients.  Even though qemu NBD clients always send requests
that are aligned to 512 bytes, we must be prepared for non-qemu
clients that don't care about alignment (even if it means they
are less efficient).  Our use of blk_read() and blk_write() was
silently operating on the wrong file offsets when the client
made an unaligned request, corrupting the client's data (but
as the client already has control over the file we are serving,
I don't think it is a security hole, per se, just a data
corruption bug).

Note that in the case of NBD_CMD_READ, an unaligned length could
cause us to return up to 511 bytes of uninitialized trailing
garbage from blk_try_blockalign() - hopefully nothing sensitive
from the heap's prior usage is ever leaked in that manner.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Tested-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 1461249750-31928-1-git-send-email-eblake@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Eric Blake 2016-04-21 08:42:30 -06:00 committed by Peter Maydell
parent 8d0d9b9f67
commit df7b97ff89
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
nbd/server.c
View File

@ -1091,9 +1091,8 @@ static void nbd_trip(void *opaque)
} }
} }
ret = blk_read(exp->blk, ret = blk_pread(exp->blk, request.from + exp->dev_offset,
(request.from + exp->dev_offset) / BDRV_SECTOR_SIZE, req->data, request.len);
req->data, request.len / BDRV_SECTOR_SIZE);
if (ret < 0) { if (ret < 0) {
LOG("reading from file failed"); LOG("reading from file failed");
reply.error = -ret; reply.error = -ret;
@ -1115,9 +1114,8 @@ static void nbd_trip(void *opaque)
TRACE("Writing to device"); TRACE("Writing to device");
ret = blk_write(exp->blk, ret = blk_pwrite(exp->blk, request.from + exp->dev_offset,
(request.from + exp->dev_offset) / BDRV_SECTOR_SIZE, req->data, request.len);
req->data, request.len / BDRV_SECTOR_SIZE);
if (ret < 0) { if (ret < 0) {
LOG("writing to file failed"); LOG("writing to file failed");
reply.error = -ret; reply.error = -ret;