tools/virtiofsd/passthrough_ll: Fix double close()
On success, the fdopendir() call closes fd. Later on the error path we try to close an already-closed fd. This can lead to use-after-free. Fix by only closing the fd if the fdopendir() call failed. Cc: qemu-stable@nongnu.org Fixes: b39bce121b (add dirp_map to hide lo_dirp pointers) Reported-by: Coverity (CID 1421933 USE_AFTER_FREE) Suggested-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20200321120654.7985-1-philmd@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
This commit is contained in:
parent
d4ff109373
commit
e1cd92d95c
@ -1520,8 +1520,7 @@ out_err:
|
||||
if (d) {
|
||||
if (d->dp) {
|
||||
closedir(d->dp);
|
||||
}
|
||||
if (fd != -1) {
|
||||
} else if (fd != -1) {
|
||||
close(fd);
|
||||
}
|
||||
free(d);
|
||||
|
Loading…
x
Reference in New Issue
Block a user